fix(multiframe): metadata handling of NM studies and loading order #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onTable - Added a customizable dropdown menu for managing segmentations, including options to add, edit, remove, and export segmentations. - Refactored SegmentationHeader and SegmentationSelectorHeader to utilize the new dropdown menu structure. - Improved code organization by passing context props to child components for better reusability. - Updated documentation comments in commandsModule for clarity. This update improves user interaction with segmentation features and streamlines the codebase.
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/multi-frame
|
| Run status |
|
| Run duration | 02m 18s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates across multiple files to improve functionality, fix issues, and update dependencies. The most important changes include removing specific headers from NGINX configurations, updating dependencies in multiple
package.jsonfiles, and enhancing the segmentation panel with custom dropdown menu content.NGINX Configuration Updates:
Cross-Origin-Opener-PolicyandCross-Origin-Embedder-Policyheaders from.docker/Viewer-v3.x/default.conf.templateand.docker/Viewer-v3.x/default.ssl.conf.template. [1] [2]Dependency Updates:
@cornerstonejsdependencies to version^2.2.20in variouspackage.jsonfiles. [1] [2] [3] [4] [5] [6]Webpack Configuration:
process.env.NODE_ENVin.webpack/webpack.base.jsand adjusted Babel loader plugins based on the build mode. [1] [2]Segmentation Panel Enhancements:
PanelSegmentation.tsxto enhance the segmentation panel with additional functionality. [1] [2] [3]Miscellaneous Improvements:
init.tsxto ensure metadata is properly managed during image loading. [1] [2]DicomJSONDataSource/index.js.DicomLocalDataSource/index.js. [1] [2] [3]